[openib-general] [PATCH] osm: fix a bug in ignroing pending transaction of Light Sweep

Eitan Zahavi eitan at mellanox.co.il
Mon Dec 18 11:35:53 PST 2006


Hal Rosenstock wrote:
> Hi Eitan,
>
> On Sat, 2006-12-16 at 13:56, Eitan Zahavi wrote:
>   
>> Hi Hal
>>
>> This patch provides fixes an issue discovered by the nightly regression.
>> OpenSM state machine got stack due to pending SwitchInfo transaction 
>> being ignored since one of the queries for SwitchInfo
>> failed (due to bad-link).
>> The patch below simply avoids aborting the wait for all SwitchInfo 
>> requests to return.
>>
>> I think this issue might have hurt us in other situations too sine it 
>> aborted the wait on "CHANGE DETECTED" too.
>> CHANGE_DETECTED is fired on the first switch that reported "Change Bit".
>>
>> It is possible that the issue is showing up as we added incremental 
>> support (e.g. for routing)
>> Since only of there are no other SMP's sent during the heavy sweep we 
>> will get the
>> "NO_PENDING_TRANSACTIONS" signal caused by the SwitchInfo requests
>>     
>
> So is the same issue applicable to OFED 1.1 ?
>   
Yes it is.
>   
>> Eitan
>>
>> Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il >
>>
>>  osm/opensm/osm_state_mgr.c |    5 ++---
>>  1 files changed, 2 insertions(+), 3 deletions(-)
>>     
>
> Thanks. Applied.
>
> -- Hal
>
>
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>   





More information about the general mailing list