[openib-general] Re: ipoib: outstanding patches

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [openib-general] Re: ipoib: outstanding patches
> 
>  > ipoib_all_neigh_issues_2.patch
> 
> Crazy idea: can we just get away with never clearing ops->destructor?
> ipoib_neigh_destructor() checks if the neighbour structure has an
> IPoIB structure attached and does nothing if it doesn't.  So does it
> hurt to leave ops->destructor set to ipoib_neigh_destructor() forever?

We cant leave the destructor set after unloading the module.

This is because ops structure is not per neighbour and not per device.
So while kernel destroys all neighbours it created for our
device, the ops structure is shared with neighbours for other devices.

-- 
MST