[openib-general] RE: [PATCH] osm: Adding revision empty file

[Hal Rosenstock]

Hi again Ofer,

On Wed, 2006-03-01 at 09:17, Ofer Gigi wrote:
> Hi Hal,
> https://openib.org/svn/gen2/trunk/src/userspace/management
> Revision 5543 - up to date.
> 
> I wasn't at the loop if and when you discussed it - what did you decide
> then?

It wasn't needed and should be removed (that the makefile could take
care of what needed to be done).

> All I know is that the file is not created (maybe permissions problem)
> during make, and therefore the make fails.

I left out the second part before:
if cmp -s ./../include/opensm/osm_svn_revision_new.h \
          ./../include/opensm/osm_svn_revision.h ; \
then \
        rm ./../include/opensm/osm_svn_revision_new.h ; \
else \
        mv ./../include/opensm/osm_svn_revision_new.h \
           ./../include/opensm/osm_svn_revision.h ; \
fi

I just tried this and it works fine for me.

Can you send me the build transcript so I can try to understand why this
fails for you ?

-- Hal

> 
> Thanks!
> Ofer 
> 
> -----Original Message-----
> From: Hal Rosenstock [mailto:halr at voltaire.com] 
> Sent: Wednesday, March 01, 2006 3:55 PM
> To: Ofer Gigi
> Cc: OPENIB
> Subject: Re: [PATCH] osm: support for trivial PKey manager
> 
> Hi Ofer,
> 
> On Wed, 2006-03-01 at 08:42, Ofer Gigi wrote:
> > Hi Hal,
> > 
> > Please add an empty file 
> > management/osm/include/opensm/osm_svn_revision.h
> > 
> > This file is needed since during the build process we write into it
> the revision. When the file doesn't exists the writing fails.
> 
> What svn version are you at ?
> 
> I thought we already went through a cycle on this. Either way I thought
> the makefile generated creates this file:
> 
> if test '!' -d './.svn'; then \
>         echo -n Exported revision >>
> ./../include/opensm/osm_svn_revision_new.h ; \
> else \
>         svnversion -n ./.. >> ./../include/opensm/osm_svn_revision_new.h
> ; \
> fi ; \
> 
> Is there some permission problem which prevents this ?
> 
> -- Hal
> 
> > Thanks
> > 
> > Ofer G.
> > 
> > Signed-off-by:  Ofer Gigi <oferg at mellanox.co.il>
> >