[openib-general] RE: [PATCH] osm: Adding revision empty file

[Ofer Gigi]

Hi Hal,
Please see below what Vlad wrote - I did the same and got the same
error, both when trying it on the trunck and on our branch.

Thanks!
OFer 

-----Original Message-----
From: Vladimir Sokolovsky 
Sent: Wednesday, March 01, 2006 12:22 PM
To: Yael Kalka
Cc: Tziporet Koren
Subject: OSM make dist fails in openib branch 1.0

 
Yael,
Please check osm make dist:

To reproduce:

	cd src/userspace/management/osm
	./autogen.sh
	./configure --disable-libcheck
	make dist


make[1]: Entering directory
`/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
 cd . && /bin/sh
/tmp/openib_branch1.0/src/userspace/management/osm/osmtest/config/missin
g --run automake-1.9 --foreign  Makefile  cd . && /bin/sh
./config.status Makefile depfiles
config.status: creating Makefile
config.status: executing depfiles commands
make[1]: Leaving directory
`/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
make[1]: Entering directory
`/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
make[1]: *** No rule to make target `opensm/osm_svn_revision.h', needed
by `distdir'.  Stop.
make[1]: Leaving directory
`/tmp/openib_branch1.0/src/userspace/management/osm/osmtest'
make: *** [distdir] Error 1

Regards,
Vladimir

-----Original Message-----
From: Hal Rosenstock [mailto:halr at voltaire.com] 
Sent: Wednesday, March 01, 2006 4:29 PM
To: Ofer Gigi
Cc: OPENIB; Yael Kalka; Eitan Zahavi; Vladimir Sokolovsky; Tziporet
Koren
Subject: RE: [PATCH] osm: Adding revision empty file

Hi again Ofer,

On Wed, 2006-03-01 at 09:17, Ofer Gigi wrote:
> Hi Hal,
> https://openib.org/svn/gen2/trunk/src/userspace/management
> Revision 5543 - up to date.
> 
> I wasn't at the loop if and when you discussed it - what did you
decide
> then?

It wasn't needed and should be removed (that the makefile could take
care of what needed to be done).

> All I know is that the file is not created (maybe permissions problem)
> during make, and therefore the make fails.

I left out the second part before:
if cmp -s ./../include/opensm/osm_svn_revision_new.h \
          ./../include/opensm/osm_svn_revision.h ; \
then \
        rm ./../include/opensm/osm_svn_revision_new.h ; \
else \
        mv ./../include/opensm/osm_svn_revision_new.h \
           ./../include/opensm/osm_svn_revision.h ; \
fi

I just tried this and it works fine for me.

Can you send me the build transcript so I can try to understand why this
fails for you ?

-- Hal

> 
> Thanks!
> Ofer 
> 
> -----Original Message-----
> From: Hal Rosenstock [mailto:halr at voltaire.com] 
> Sent: Wednesday, March 01, 2006 3:55 PM
> To: Ofer Gigi
> Cc: OPENIB
> Subject: Re: [PATCH] osm: support for trivial PKey manager
> 
> Hi Ofer,
> 
> On Wed, 2006-03-01 at 08:42, Ofer Gigi wrote:
> > Hi Hal,
> > 
> > Please add an empty file 
> > management/osm/include/opensm/osm_svn_revision.h
> > 
> > This file is needed since during the build process we write into it
> the revision. When the file doesn't exists the writing fails.
> 
> What svn version are you at ?
> 
> I thought we already went through a cycle on this. Either way I
thought
> the makefile generated creates this file:
> 
> if test '!' -d './.svn'; then \
>         echo -n Exported revision >>
> ./../include/opensm/osm_svn_revision_new.h ; \
> else \
>         svnversion -n ./.. >>
./../include/opensm/osm_svn_revision_new.h
> ; \
> fi ; \
> 
> Is there some permission problem which prevents this ?
> 
> -- Hal
> 
> > Thanks
> > 
> > Ofer G.
> > 
> > Signed-off-by:  Ofer Gigi <oferg at mellanox.co.il>
> >