[openib-general] Re: [TRIVIAL PATCH] Remove .PHONY subtarget for osm_svn_revision.h generation [was: Re: [PATCH] osm: Adding revision empty file]

Michael S. Tsirkin mst at mellanox.co.il
Thu Mar 2 13:16:22 PST 2006


Quoting r. Sasha Khapyorsky <sashak at voltaire.com>:
> Subject: [TRIVIAL PATCH] Remove .PHONY subtarget for osm_svn_revision.h generation [was: Re: [PATCH] osm: Adding revision empty file]
> 
> On 09:59 Thu 02 Mar     , Hal Rosenstock wrote:
> > 
> > Thanks. Applied (to both trunk and 1.0 branch).
> 
> Ok. Then one more cleanup.
> 
> Sasha.
> 
> 
> Remove obsolete .PHONY subtarget for osm_svn_revision.h generation.
> 
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
> 
>  osm/opensm/Makefile.am |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/osm/opensm/Makefile.am b/osm/opensm/Makefile.am
> index 447176a..fa9c006 100644
> --- a/osm/opensm/Makefile.am
> +++ b/osm/opensm/Makefile.am
> @@ -11,8 +11,7 @@ endif
>  
>  if OSMV_OPENIB
>  BUILT_SOURCES = $(srcdir)/../include/opensm/osm_svn_revision.h
> -.PHONY: always
> -$(srcdir)/../include/opensm/osm_svn_revision.h: always
> +$(srcdir)/../include/opensm/osm_svn_revision.h:
>  	echo -n "#define OSM_SVN_REVISION \"" >$(srcdir)/../include/opensm/osm_svn_revision_new.h ; \
>  	if test '!' -d '$(srcdir)/.svn'; then \
>  		echo -n Exported revision >> $(srcdir)/../include/opensm/osm_svn_revision_new.h ; \

Why is this obsolete?
The reason I did this was to do a version check on each compile.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies



More information about the general mailing list