[openib-general] Re: [TRIVIAL PATCH] Remove .PHONY subtarget for osm_svn_revision.h generation [was: Re: [PATCH] osm: Adding revision empty file]

[Sasha Khapyorsky]

[ Please add my address to Cc: ]

On 23:16 Thu 02 Mar     , Michael S. Tsirkin wrote:
> > 
> > diff --git a/osm/opensm/Makefile.am b/osm/opensm/Makefile.am
> > index 447176a..fa9c006 100644
> > --- a/osm/opensm/Makefile.am
> > +++ b/osm/opensm/Makefile.am
> > @@ -11,8 +11,7 @@ endif
> >  
> >  if OSMV_OPENIB
> >  BUILT_SOURCES = $(srcdir)/../include/opensm/osm_svn_revision.h
> > -.PHONY: always
> > -$(srcdir)/../include/opensm/osm_svn_revision.h: always
> > +$(srcdir)/../include/opensm/osm_svn_revision.h:
> >  	echo -n "#define OSM_SVN_REVISION \"" >$(srcdir)/../include/opensm/osm_svn_revision_new.h ; \
> >  	if test '!' -d '$(srcdir)/.svn'; then \
> >  		echo -n Exported revision >> $(srcdir)/../include/opensm/osm_svn_revision_new.h ; \
> 
> Why is this obsolete?
> The reason I did this was to do a version check on each compile.

You want to track current SVN revision too, I see now.

Hal, please ignore this patch.

Sasha.