[openib-general] [PATCH] Don't require create_ah and modify_port provider methods

[Steve Wise]

On Wed, 2006-03-15 at 10:41 -0800, Grant Grundler wrote:
> On Wed, Mar 15, 2006 at 11:13:28AM -0600, Steve Wise wrote:
> > Roland,
> > 
> > Here is a patch that allows me to remove all the stub/ENOSYS methods
> > from the chelsio provider.  I tested this on the main trunk by running
> > ibv_rc_pingpong and rping over mthca.
> 
> Steve, what's wrong with chelsio driver providing ENOSYS stubs?
> 
> All you are doing is making the code path longer for
> drivers that do provide those entry points.
> 
> grant
> 

This patch is in response to a review comment from Roland.  He didn't
want providers to have to stub these. 

Steve.



---snipit from original review comment---


 > +static int iwch_process_mad(struct ib_device *ibdev,
 > +			    int mad_flags,
 > +			    u8 port_num,
 > +			    struct ib_wc *in_wc,
 > +			    struct ib_grh *in_grh,
 > +			    struct ib_mad *in_mad, struct ib_mad *out_mad)
 > +{
 > +	PDBG("%s:%s:%u\n", __FILE__, __FUNCTION__, __LINE__);
 > +	return -ENOSYS;
 > +}

I'd rather fix the core so that this function (and all the other
-ENOSYS stubs) never get called, rather than forcing low-level drivers
to provide stubs.  How hard is that to do?