[openib-general] [PATCH] Don't require create_ah and modify_port provider methods

Sean Hefty mshefty at ichips.intel.com
Wed Mar 15 11:12:39 PST 2006


Steve Wise wrote:
>>>Here is a patch that allows me to remove all the stub/ENOSYS methods
>>>from the chelsio provider.  I tested this on the main trunk by running
>>>ibv_rc_pingpong and rping over mthca.
>>
>>Steve, what's wrong with chelsio driver providing ENOSYS stubs?
>>
>>All you are doing is making the code path longer for
>>drivers that do provide those entry points.
>>
>>grant
>>
> This patch is in response to a review comment from Roland.  He didn't
> want providers to have to stub these. 

I'm not even sure this is possible, but could we create an rdma_nosys() routine 
that takes a variable arguments and simply returns -ENOSYS, and set all 
unimplemented functions to reference that routine?  This could be done in the 
core, and would avoid branches in the code paths.

- Sean



More information about the general mailing list