[openib-general] Re: [PATCH] opensm: make some local functions static

[Hal Rosenstock]

On Mon, 2006-05-08 at 17:37, Sasha Khapyorsky wrote:
> This patch makes some local functions static. One unused function was
> cleaned up, other currently unused was masked.

Thanks. Applied.

One comment below:

> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
> 
>  osm/opensm/osm_node_info_rcv.c |   24 +++++++++---------
>  osm/opensm/osm_port_info_rcv.c |    2 +-
>  osm/opensm/osm_sw_info_rcv.c   |   52 +++++-----------------------------------
>  3 files changed, 20 insertions(+), 58 deletions(-)

[snip...]

> diff --git a/osm/opensm/osm_port_info_rcv.c b/osm/opensm/osm_port_info_rcv.c
> index 658d99e..bc75e71 100644
> --- a/osm/opensm/osm_port_info_rcv.c
> +++ b/osm/opensm/osm_port_info_rcv.c

[snip...]

> @@ -242,7 +202,8 @@ __osm_si_rcv_get_fwd_tbl(
>  /**********************************************************************
>   The plock must be held before calling this function.
>  **********************************************************************/
> -void
> +#if 0
> +static void
>  __osm_si_rcv_get_mcast_fwd_tbl(
>    IN const osm_si_rcv_t* const p_rcv,
>    IN osm_switch_t* const p_sw )
> @@ -347,11 +308,12 @@ __osm_si_rcv_get_mcast_fwd_tbl(
>   Exit:
>    OSM_LOG_EXIT( p_rcv->p_log );
>  }
> +#endif

How come you just #if 0'd this out ?

[snip...]

-- Hal