[openib-general] Re: [PATCH] opensm: make some local functions static

Sasha Khapyorsky sashak at voltaire.com
Mon May 8 15:07:23 PDT 2006


On 17:47 Mon 08 May     , Hal Rosenstock wrote:
> 
> > @@ -242,7 +202,8 @@ __osm_si_rcv_get_fwd_tbl(
> >  /**********************************************************************
> >   The plock must be held before calling this function.
> >  **********************************************************************/
> > -void
> > +#if 0
> > +static void
> >  __osm_si_rcv_get_mcast_fwd_tbl(
> >    IN const osm_si_rcv_t* const p_rcv,
> >    IN osm_switch_t* const p_sw )
> > @@ -347,11 +308,12 @@ __osm_si_rcv_get_mcast_fwd_tbl(
> >   Exit:
> >    OSM_LOG_EXIT( p_rcv->p_log );
> >  }
> > +#endif
> 
> How come you just #if 0'd this out ?

Below there is the code which uses this function and it is under #if 0,
so in order tp prevent warning and to be consistent with existed code...
:). Actually if it is really not necessary both the function and its
call may be removed.

Sasha.



More information about the general mailing list