[openib-general] [PATCH 5/6] Use pci_find_ht_capability() in drivers/pci/quirks.c

[Segher Boessenkool]

> You don't have any TTL in the while loop below, neither in the while
> loop in pci_find_next_ht_capability(). It's paranoid, but I'd rather
> keep a TTL in both loops (a brain-damaged capability chain in the PCI
> config space could lead to an infinite loop without any clue of what's
> going on, not easy to find out...).

There's so many other ways broken PCI headers can cause
problems, it's just not funny.  You can't catch all of
them however hard you try.

I always thought the super-over-the-top paranoia checks
in the generic PCI capability list walkers were workarounds
for problems actually observed in the field; can we do the
same for the HT-specific walker?  I.e., don't implement
the workaround before we know we need it.


Segher