[openib-general] [PATCH 5/6] Use pci_find_ht_capability() in drivers/pci/quirks.c

[Greg KH]

On Thu, Nov 09, 2006 at 10:43:25AM +0100, Segher Boessenkool wrote:
> >You don't have any TTL in the while loop below, neither in the while
> >loop in pci_find_next_ht_capability(). It's paranoid, but I'd rather
> >keep a TTL in both loops (a brain-damaged capability chain in the PCI
> >config space could lead to an infinite loop without any clue of what's
> >going on, not easy to find out...).
> 
> There's so many other ways broken PCI headers can cause
> problems, it's just not funny.  You can't catch all of
> them however hard you try.
> 
> I always thought the super-over-the-top paranoia checks
> in the generic PCI capability list walkers were workarounds
> for problems actually observed in the field; can we do the
> same for the HT-specific walker?  I.e., don't implement
> the workaround before we know we need it.

While yes, we should not in general add new workarounds before we need
them, for this quirk, you should keep the original functionality, unless
you wrote the quirk, or unless you have the hardware that needs it and
you can verify that the change works properly.

Are any of these last two options true for you?

If not, I suggest that you put the TTL logic back in just to be safe.

thanks,

greg k-h