[openib-general] [PATCH] osm_vendor_mlx_sa.c - missing status on timeout SA query

Eitan Zahavi eitan at mellanox.co.il
Wed Sep 27 21:40:11 PDT 2006


Hi Hal

Similar to the bug discovered by Yevgeny on the osm_vendor_ibumad_sa.c
the very same bug happens on osm_vendor_mlx_sa.c which fails osmtest.
The issue is that the status of the result of the query is not returned 
as the result of the SA query.

Eitan

Signed-off-by:  Eitan Zahavi <eitan at mellanox.co.il>

Index: libvendor/osm_vendor_mlx_sa.c
===================================================================
--- libvendor/osm_vendor_mlx_sa.c	(revision 9642)
+++ libvendor/osm_vendor_mlx_sa.c	(working copy)
@@ -219,7 +219,8 @@ __osmv_sa_mad_err_cb(
 
   query_res.status = IB_TIMEOUT;
   query_res.result_cnt = 0;
-
+  query_res.p_result_madw->status = IB_TIMEOUT;
+  p_madw->status = IB_TIMEOUT;
   query_res.query_type = p_query_req_copy->query_type;
 
   p_query_req_copy->pfn_query_cb( &query_res );
@@ -611,6 +612,7 @@ __osmv_send_sa_req(
              "Waiting for async event.\n" );
     cl_event_wait_on( &p_bind->sync_event, EVENT_NO_TIMEOUT, FALSE );
     cl_event_reset(&p_bind->sync_event);
+    status = p_madw->status;
   }
 
  Exit:





More information about the general mailing list