[ofa-general] Re: [PATCH 1/1] IB/iser: do not switch context when notifying the iSCSI layer on a connection failure

Roland Dreier rdreier at cisco.com
Sun Apr 1 11:10:26 PDT 2007


 > The following patch replaces the bad patch (iser_conn should not be
 > released while its workqueue is active) that I sent a few days
 > ago. Again, if it's possible, I'd like to have it merged into 2.6.21
 > (it is a bug fix).

We can still merge bug fixes, but I need some understanding of what
the bug is and what the severity is.  The changelog you sent is
inadequate, since it makes the change seem by like at most an
optimization or simplification, and doesn't mention what the bug is at
all:

 > When a connection is terminated asynchronously from the iSCSI
 > layer's perspective, iSER needs to notify the iSCSI layer that the
 > connection has failed. This was done using a workqueue (switched to
 > from a tasklet context). The context switch is not required, and
 > everything can be done from the iSER tasklet.

 - R.



More information about the general mailing list