[ofa-general] Re: [PATCH 1/1] IB/iser: do not switch context when notifying the iSCSI layer on a connection failure

[Erez Zilber]

Roland Dreier wrote:
>  > The following patch replaces the bad patch (iser_conn should not be
>  > released while its workqueue is active) that I sent a few days
>  > ago. Again, if it's possible, I'd like to have it merged into 2.6.21
>  > (it is a bug fix).
>
> We can still merge bug fixes, but I need some understanding of what
> the bug is and what the severity is.  The changelog you sent is
> inadequate, since it makes the change seem by like at most an
> optimization or simplification, and doesn't mention what the bug is at
> all:
>   

You're right. Here's a better description:

When a connection is terminated asynchronously from the iSCSI
layer's perspective, iSER needs to notify the iSCSI layer that the
connection has failed. This is done using a workqueue (switched to
from the iSER tasklet context). Meanwhile, the connection object (that 
holds the work struct) is released. If the workqueue function wasn't
called yet, it will be called later with a NULL pointer that will
crash the kernel.

The context switch (tasklet to workqueue) is not required, and 
everything can be done from the iSER tasklet. This eliminates the NULL
work struct bug (and simplifies the code).




--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi at googlegroups.com
To unsubscribe from this group, send email to open-iscsi-unsubscribe at googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---


--- Scanned by M+ Guardian Extreme Messaging Firewall by Messaging Architects ---