[openib-general] [PATCH] enable IPoIB only if broadcast join finish

[Shirley Ma]

Hi, Roland,

Please review this patch. According to IPoIB RFC4391 section 5, once IPoIB
broacast group has been joined, the interface should be ready for data
transfer. In current IPoIB implementation, the interface is UP and RUNNING
when all default multicast join successful. We hit a problem while the
broadcast join finishe and sucessful but the all hosts multicast join
failure.

Here is the patch, if possible please give your input asap, we have an
urgent customer issue need to be resolved:

diff -urpN ipoib/ipoib_multicast.c ipoib-multicast/ipoib_multicast.c
--- ipoib/ipoib_multicast.c   2006-11-29 13:57:37.000000000 -0800
+++ ipoib-multicast/ipoib_multicast.c     2007-02-04 22:34:16.000000000 -0800
@@ -402,6 +402,11 @@ static void ipoib_mcast_join_complete(in
                  queue_work(ipoib_workqueue, &priv->mcast_task);
            mutex_unlock(&mcast_mutex);
            complete(&mcast->done);
+           /*
+            * broadcast join finished, enable carrier
+            */
+           if (mcast == priv->broadcast)
+                 netif_carrier_on(dev);
            return;
      }

@@ -599,7 +604,6 @@ void ipoib_mcast_join_task(void *dev_ptr
      ipoib_dbg_mcast(priv, "successfully joined all multicast groups\n");

      clear_bit(IPOIB_MCAST_RUN, &priv->flags);
-     netif_carrier_on(dev);
 }

 int ipoib_mcast_start_thread(struct net_device *dev)

(See attached file: ipoib-multicast.patch)

Thanks
Shirley Ma
IBM Linux Technology Center
15300 SW Koll Parkway
Beaverton, OR 97006-6063
Phone(Fax): (503) 578-7638
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20070205/4821ac96/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ipoib-multicast.patch
Type: application/octet-stream
Size: 777 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20070205/4821ac96/attachment.obj>