[openib-general] [RFC] [PATCH 1/1] ib_sa: add InformInfo registration for Notice reports

[Hal Rosenstock]

On Thu, 2006-12-14 at 19:20, Sean Hefty wrote:

Another comment/question:

> diff --git a/drivers/infiniband/core/notice.c b/drivers/infiniband/core/notice.c
> new file mode 100644
> index 0000000..038878d
> --- /dev/null
> +++ b/drivers/infiniband/core/notice.c

> +static void inform_event_handler(struct ib_event_handler *handler,
> +				struct ib_event *event)
> +{
> +	struct inform_device *dev;
> +
> +	dev = ib_get_client_data(event->device, &inform_client);
> +	if (!dev)
> +		return;
> +
> +	switch (event->event) {
> +	case IB_EVENT_PORT_ERR:
> +	case IB_EVENT_LID_CHANGE:
> +	case IB_EVENT_SM_CHANGE:
> +	case IB_EVENT_CLIENT_REREGISTER:
> +		inform_groups_lost(&dev->port[event->element.port_num -
> +					      dev->start_port]);
> +		break;
> +	default:
> +		break;
> +	}
> +}

Are groups lost on LID change ? (Not sure what port error means). Also,
guess it is safest to assume lost on SM change although that might not
be the case. One could query via InformInfoRecords.

-- Hal