[openib-general] [RFC] [PATCH 1/1] ib_sa: add InformInfo registration for Notice reports

[Hal Rosenstock]

On Thu, 2006-12-14 at 19:20, Sean Hefty wrote:

A few more comments and questions below:

> diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c
> index ea78687..88c228c 100644
> --- a/drivers/infiniband/core/sa_query.c
> +++ b/drivers/infiniband/core/sa_query.c

> +enum {
> +	IB_SA_SM_TRAP_GID_IN_SERVICE			= 64,
> +	IB_SA_SM_TRAP_GID_OUT_OF_SERVICE		= 65,
> +	IB_SA_SM_TRAP_CREATE_MC_GROUP			= 66,
> +	IB_SA_SM_TRAP_DELETE_MC_GROUP			= 67,
> +	IB_SA_SM_TRAP_PORT_CHANGE_STATE			= 128,
> +	IB_SA_SM_TRAP_LINK_INTEGRITY			= 129,
> +	IB_SA_SM_TRAP_EXCESSIVE_BUFFER_OVERRUN		= 130,
> +	IB_SA_SM_TRAP_FLOW_CONTROL_UPDATE_EXPIRED	= 131,

Why not 144 and 145 too ?

> +	IB_SA_SM_TRAP_BAD_M_KEY				= 256,
> +	IB_SA_SM_TRAP_BAD_P_KEY				= 257,
> +	IB_SA_SM_TRAP_BAD_Q_KEY				= 258,

What about 259 ?

> +	IB_SA_SM_TRAP_ALL				= 0xFFFF
> +};
> +
> +#define IB_SA_INFORM_GID				IB_SA_COMP_MASK( 0)
> +#define IB_SA_INFORM_LID_RANGE_BEGIN			IB_SA_COMP_MASK( 1)
> +#define IB_SA_INFORM_LID_RANGE_END			IB_SA_COMP_MASK( 2)
> +/* reserved:								 3 */
> +#define IB_SA_INFORM_IS_GENERIC				IB_SA_COMP_MASK( 4)
> +#define IB_SA_INFORM_SUBCRIBE				IB_SA_COMP_MASK( 5)
> +#define IB_SA_INFORM_TYPE				IB_SA_COMP_MASK( 6)
> +
> +#define IB_SA_INFORM_TRAP_NUMBER			IB_SA_COMP_MASK( 7)
> +#define IB_SA_INFORM_DEVICE_ID				IB_SA_COMP_MASK( 7)
> +#define IB_SA_INFORM_QPN				IB_SA_COMP_MASK( 8)
> +/* reserved:								 9 */
> +#define IB_SA_INFORM_RESP_TIME				IB_SA_COMP_MASK(10)
> +/* reserved:								11 */
> +#define IB_SA_INFORM_PRODUCER_TYPE			IB_SA_COMP_MASK(12)
> +#define IB_SA_INFORM_VENDOR_ID				IB_SA_COMP_MASK(12)

Component mask is meaningless for InformInfo so these shouldn't be
needed.

-- Hal