[ofa-general] Command specification of ca_name and ca_port

[Ira Weiny]

On Tue, 24 Jul 2007 04:33:06 +0300
Sasha Khapyorsky <sashak at voltaire.com> wrote:

> Hi David,
> 
> On 09:52 Mon 23 Jul     , David McMillen wrote:
> > 
> >  There are a standard set of command line options that allow specification of 
> >  the CA to use for sending the requests.  I'm adding these to programs that 
> >  don't have them, since they are very useful when diagnosing a node connected 
> >  to multiple subnets.  Even if you discount multiple subnets on purpose, 
> >  sometimes this happens when the hardware connecting all of the CA ports to 
> >  the same place gets broken, and that is when you need diagnostics that can 
> >  help figure out what is where.
> > 
> >  The standard options are:
> > 
> >        -C <ca_name>    use the specified ca_name.
> > 
> >        -P <ca_port>    use the specified ca_port.
> > 
> >        -t <timeout_ms> override the default timeout for the solicited mads.
> > 
> >  My problem is that saquery already uses -C and -P, although the -t exists 
> >  for the expected purpose.  Also, ibcheckerrs already uses -t for specifying 
> >  the threshold file.
> 
> I think unified command line options over diags are good thing, so I
> guess reasonable renaming should be acceptable.

I agree, however right now saquery does not support specifying the ca_name or
ca_port, so you would have to add that support.

> 
> > 
> >  Changing the timeout for ibcheckerrs isn't critical, but not being able to 
> >  do it doesn't seem right.  However, the saquery command could be really 
> >  handy for figuring out split fabrics, and is useful to those of us that 
> >  connect to multiple subnets.
> > 
> >  Does anybody have a useful suggestion?
> 
> '-T' for the threshold file?

That sounds good.

>
> But it is easy part - saquery renames are
> less intuitive :(. Probably just lower case? Or special query option
> (-q or -Q), so queries could be specified as -qP, -qC?
> 

I disagree with this because ~50% of the options are query's, it's primary
purpose is to query, and most of the other options change the format of the
output of the query.  Therefore, I don't think a -q should be required for a
query.  I think that seems redundant.

Perhaps just changing the current option to -c,-p, and adding -C and -P would
be best.  I know this might break some scripts out there, particularly mine,
but I think it is the right thing to do if you really want consistency.

Thoughts?
Ira