[ofa-general] Re: opensm console -what is it?

[Hal Rosenstock]

On Wed, 2007-03-28 at 11:23, Ira Weiny wrote:
> On Wed, 28 Mar 2007 16:09:23 +0200
> Sasha Khapyorsky <sashak at voltaire.com> wrote:
> 
> > On Wed, 2007-03-28 at 14:48 +0200, Michael S. Tsirkin wrote:
> 
> <snip>
> 
> > > 
> > > Hmm .. how does one exit?
> > 
> > You cannot exit from local console, 'quit' will work with remote
> > console. If you want just to kill OpenSM you can use ^C.
> > 
> > Sasha
> 
> Sasha is correct.  Here at LLNL we are making extensive use of the socket
> console to be able to change log levels and other parameters after opensm has
> been run as a daemon.
> 
> The local console was kept as a feature for developers to make working with
> that interface easier.  (And it was there before the socket was added so it did
> not cost much.)  I believe all the other commands should work as advertised in
> the local mode.
> 
> Here is a patch to the help menu of the quit command which should make things
> clearer.

Sure. How about also the following on top of your change:

OpenSM/osm_console.c: Indicate use ctl-c to quit in local mode

Signed-off-by: Hal Rosenstock <halr at voltaire.com>

diff --git a/osm/opensm/osm_console.c b/osm/opensm/osm_console.c
index 4577ab7..5ce9c88 100644
--- a/osm/opensm/osm_console.c
+++ b/osm/opensm/osm_console.c
@@ -89,7 +89,7 @@ static void help_command(FILE *out, int
 
 static void help_quit(FILE *out, int detail)
 {
-	fprintf(out, "quit (not valid in local mode)\n");
+	fprintf(out, "quit (not valid in local mode; use ctl-c)\n");
 }
 
 



> Ira
> 
> 
> ______________________________________________________________________
> 
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general