[ofa-general] [query] SMI nodeinfo, port_info structures

Roland Dreier rdreier at cisco.com
Thu May 3 22:12:40 PDT 2007


[please try to keep your line lengths below 80 columns]

 > we can avoid this situation (duplicate declarations of same
 > structre) by declaring the above mentioned structures in the core
 > layer.

I think a patch moving structures defined by the IB spec to a more
appropriate location would be fine.

 > Some fields in those structures have big endian (__bexx) alignment
 > and others have CPU (uxx) alignment.
 > 
 > e.g: in struct port_info declared in ipath driver (ipath_mad.c),
 > the mkey is declared as __be64 mkey whereas the local port number
 > is declared as u8 local_port_num.

Think about it... what could endianess mean for a single-byte field?



More information about the general mailing list