[ofa-general] Re: [PATCH] IB/mlx4 mlx4_ib: commands timeout

Michael S. Tsirkin mst at dev.mellanox.co.il
Mon May 7 07:06:19 PDT 2007


> Quoting Tziporet Koren <tziporet at dev.mellanox.co.il>:
> Subject: Re: [ofa-general] Re: [PATCH] IB/mlx4 mlx4_ib: commands timeout
> 
> Eli Cohen wrote:
> >On Mon, 2007-05-07 at 15:04 +0300, Michael S. Tsirkin wrote:
> >  
> >>How likely is this to help in practice?
> >>
> >>    
> >Like I said, when the system is very busy. In this case the command may
> >actually complete very soon but wait_for_completion_timeout() will
> >nevertheless return zero since the task did not get CPU time before the
> >specified timeout expired. In this case we would like to check if done
> >is signaled and thus not fail the command.
> >  
> This is not a theoretical issue - we actually saw this problem here with 
> some tests.

I wonder whether this applicable to mthca as well then.

-- 
MST



More information about the general mailing list