[ofa-general] Re: [PATCH] IB/mlx4 mlx4_ib: commands timeout

[Roland Dreier]

 > When the system is busy it may happen that the command actually
 > completed but it took more than the specified timeout till the
 > task executing the command was actually given CPU time. This test
 > checks that the completion is really missing before failing.

 > +	if (!wait_for_completion_timeout(&context->done, msecs_to_jiffies(timeout)))
 > +		if (!context->done.done) {
 > +			err = -EBUSY;
 > +			goto out;
 > +		}

This seems more like a bug in wait_for_completion_timeout().  Anyway,
it's definitely not OK to poke inside the definition of struct
completion in driver code, so we need to find a different way to solve
this.

BTW the same completion handling code is in mthca -- is this also a
problem there?

 - R.