[ofa-general] [IPoIB][RFC] remove redundant gid query

James Lentini jlentini at netapp.com
Tue May 8 11:38:06 PDT 2007


Both ipoib_add_port() and ipoib_mcast_join_task() query the GID at 
index 0 to setup the ipoib_dev_priv structure's local_gid and the 
net_device structure's dev_addr. There does not appear to be a way for 
ipoib_mcast_join_task() to be executed before ipoib_add_port() 
completes. Therefore, the work done in ipoib_mcast_join_task() appears 
to be redundant.

Signed-off-by: James Lentini <jlentini at netapp.com>

--- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c	2007-05-08 14:34:15.000000000 -0400
+++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c	2007-05-08 14:34:07.000000000 -0400
@@ -523,11 +523,6 @@ void ipoib_mcast_join_task(struct work_s
 	if (!test_bit(IPOIB_MCAST_RUN, &priv->flags))
 		return;
 
-	if (ib_query_gid(priv->ca, priv->port, 0, &priv->local_gid))
-		ipoib_warn(priv, "ib_gid_entry_get() failed\n");
-	else
-		memcpy(priv->dev->dev_addr + 4, priv->local_gid.raw, sizeof (union ib_gid));
-
 	{
 		struct ib_port_attr attr;
 



More information about the general mailing list