[ofa-general] Re: [IPoIB][RFC] remove redundant gid query

Roland Dreier rdreier at cisco.com
Thu May 17 10:41:08 PDT 2007


 > Both ipoib_add_port() and ipoib_mcast_join_task() query the GID at 
 > index 0 to setup the ipoib_dev_priv structure's local_gid and the 
 > net_device structure's dev_addr. There does not appear to be a way for 
 > ipoib_mcast_join_task() to be executed before ipoib_add_port() 
 > completes. Therefore, the work done in ipoib_mcast_join_task() appears 
 > to be redundant.

It does look like we're doing some work we don't need to do.  However
ipoib_add_port() could run before an SM has brought up the local port,
so the GID prefix might change later.

I'm not sure what the best way to clean this up is.

 - R.



More information about the general mailing list