[ofa-general] Re: [IBSIM] Parse sim cmds by name not first character

Sasha Khapyorsky sashak at voltaire.com
Mon Aug 18 16:01:13 PDT 2008


On 15:50 Mon 18 Aug     , Al Chu wrote:
> 
> The reason is that the ordering of the if statements now matters.  If I
> add a new command called "DoSomething", it must come after the "Dump"
> comparison, otherwise the command "D" could take the "DoSomething"
> branch.

Sure, order will matter - new commands will be at end.

Sasha

> We can add a comments or something to document this.  It's
> obviously just a style difference.
> 
> > >
> > > But we would require
> > > whitespace between the command and options for that to work.
> > 
> > This is fine.
> > 
> > What I meant is follow:
> > 
> > 	unsigned cmd_len = 0;
> > 
> > 	while (isalpha(line[cmd_len]))
> > 		cmd_len++;
> > 
> > 	if (!strncasecmp(line, "Dump", cmdlen))
> > 		...
> > 
> > In this case strings "D", "du", etc. will be resolved as "Dump" command.
> 
> Ok.  I see what you were thinking now.  
> 
> Al
> 
> > Sasha
> -- 
> Albert Chu
> chu11 at llnl.gov
> 925-422-5311
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory
> 



More information about the general mailing list