[ofa-general] [PATCH] IB/core - ib_wr_opcode change to add IB_WR_LSO breaks ib_ipath

Or Gerlitz ogerlitz at voltaire.com
Thu Jan 3 00:45:36 PST 2008


Ralph Campbell wrote:
> The ib_ipath driver depends on /usr/include/infiniband/verbs.h
> enum ibv_wr_opcode matching the kernel's ib_verbs.h
> enum ib_wr_opcode. The recent change to add IB_WR_LSO breaks this.
> 
> Now, you may argue that the kernel should not depend on this equivalence
> but you would then need to define IBV_WR_RDMA_WRITE, etc. in some
> kernel header file and do a table look up to map from user to
> kernel opcode values. Since I don't see any other code which depends
> on the value of IB_WR_LSO, I think the following patch is the right
> fix.
> 
> This should be applied to 2.6.24 and 2.6.25.

SO in a way, putting IB_WR_LSO where it was broke the ABI for libibpath.

Eli,

Can you please apply this change to the patch set which you consider as 
candidate for upstream merging?

Or.






More information about the general mailing list