[ofa-general] [PATCH] IB/core - ib_wr_opcode change to add IB_WR_LSO breaks ib_ipath

[Eli Cohen]

OK, I'll push this to ofed.

On Thu, 2008-01-03 at 10:45 +0200, Or Gerlitz wrote:
> Ralph Campbell wrote:
> > The ib_ipath driver depends on /usr/include/infiniband/verbs.h
> > enum ibv_wr_opcode matching the kernel's ib_verbs.h
> > enum ib_wr_opcode. The recent change to add IB_WR_LSO breaks this.
> > 
> > Now, you may argue that the kernel should not depend on this equivalence
> > but you would then need to define IBV_WR_RDMA_WRITE, etc. in some
> > kernel header file and do a table look up to map from user to
> > kernel opcode values. Since I don't see any other code which depends
> > on the value of IB_WR_LSO, I think the following patch is the right
> > fix.
> > 
> > This should be applied to 2.6.24 and 2.6.25.
> 
> SO in a way, putting IB_WR_LSO where it was broke the ABI for libibpath.
> 
> Eli,
> 
> Can you please apply this change to the patch set which you consider as 
> candidate for upstream merging?
> 
> Or.
> 
> 
> 
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general