[ofa-general] Re: [PATCH 2/3 v2] mlx4: multicast cast loopback block

[Roland Dreier]

 > Ron will be here later this week and then he can make the check and resend.

sigh... I can fix it up this time but it's such a pointless waste to
send patches with problems when a trivial, easy-to-run script can tell
you how to fix them.

 > personally, I find !! code somehow hard to read, but if this is the
 > common practice in such cases, we can fix that...

not a big deal either way.  I prefer my way because if I have

	if (something)
		func(lots, of, parameters, all, the, same, except, 1);
	else
		func(lots, of, parameters, all, the, same, except, 0);

then it's not always so clear what the difference between the two
function calls really is without reading carefully.  By putting
!!something into the call:

	func(lots, of, parameters, all, the, same, except, !!something);

it becomes obvious how the value of something is used.

 - R.