[ofa-general] Re: [PATCH 2/3 v2] mlx4: multicast cast loopback block

[Or Gerlitz]

Roland Dreier wrote:
> sigh... I can fix it up this time but it's such a pointless waste to send patches with problems when a trivial, easy-to-run script can tell you how to fix them.
Understood. Will act to have myself and people here run it before 
sending next times ... Don't bother to fix it yourself, there's still 
time, Ron will fix and resend.
> not a big deal either way.  I prefer my way because if I have
> 	if (something)
> 		func(lots, of, parameters, all, the, same, except, 1);
> 	else
> 		func(lots, of, parameters, all, the, same, except, 0);
> then it's not always so clear what the difference between the two
> function calls really is without reading carefully.  By putting
> !!something into the call:
>
> 	func(lots, of, parameters, all, the, same, except, !!something);
>
> it becomes obvious how the value of something is used.
yes, I see the point, once you get used to it, !! code is clearer than 
func(lots, of, parameters, all, the, same, except, X). So Ron will fix 
this as well.

Or.

Or.