[ofa-general] Re: [PATCH] opensm/osm_perfmgr.c: Increase size of memory allocation in __collect_guids

Sasha Khapyorsky sashak at voltaire.com
Wed Feb 4 13:11:06 PST 2009


On 15:58 Wed 04 Feb     , Hal Rosenstock wrote:
> On Wed, Feb 4, 2009 at 2:00 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> > On 07:57 Tue 03 Feb     , Hal Rosenstock wrote:
> >>
> >> Patch to increase size of monitored node in
> >> osm_perfmgr.c::__collect_guids. Redirection table is indexed by actual
> >> port number.
> >
> > There are couple of validations like (port > p_mon_node->redir_tbl_size)
> > in osm_perfmgr.c. Would it be correct after proposed change?
> 
> I see an issue with those tests which I will fix in a subsequent patch.

Could you fix this and post v2? - putting bugs in a main stream is bad
in general and practically also complicates things like bisecting.

Sasha



More information about the general mailing list