***SPAM*** Re: [ofa-general] Re: [PATCH] opensm/osm_perfmgr.c: Increase size of memory allocation in __collect_guids

[Hal Rosenstock]

On Wed, Feb 4, 2009 at 4:11 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> On 15:58 Wed 04 Feb     , Hal Rosenstock wrote:
>> On Wed, Feb 4, 2009 at 2:00 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
>> > On 07:57 Tue 03 Feb     , Hal Rosenstock wrote:
>> >>
>> >> Patch to increase size of monitored node in
>> >> osm_perfmgr.c::__collect_guids. Redirection table is indexed by actual
>> >> port number.
>> >
>> > There are couple of validations like (port > p_mon_node->redir_tbl_size)
>> > in osm_perfmgr.c. Would it be correct after proposed change?
>>
>> I see an issue with those tests which I will fix in a subsequent patch.
>
> Could you fix this and post v2?

I can.

> - putting bugs in a main stream is bad
> in general and practically also complicates things like bisecting.

It was leaving an old bug in rather than adding a new one.

-- Hal

> Sasha
>