[ofa-general] Re: [PATCH] opensm/osm_ucast_mgr.c: Add error numbers for some OSM_LOG prin

Sasha Khapyorsky sashak at voltaire.com
Sat Feb 14 08:22:54 PST 2009


Hi Hal,

On 08:51 Sat 14 Feb     , hnrose at comcast.net wrote:
> 
> From 3b8e45eaaeaac7bd34b60dfd432469cafc6caef7 Mon Sep 17 00:00:00 2001

Please don't put this line ("From ...") in patch message body - it marks
start of message in mbox file format and breaks things like 'git rebase'
and similar. (At least mask this line with '> ' character).

> From: Hal Rosenstock <hal.rosenstock at gmail.com>
> Date: Tue, 10 Feb 2009 07:14:32 -0500
> Subject: [PATCH] opensm/osm_ucast_mgr.c: Add error numbers for some OSM_LOG prints

Actually there is no reason to repeat email header in a commit message.

> 
> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>

Applied. Thanks.

Sasha



More information about the general mailing list