[ofa-general] Re: [PATCH] opensm/osm_ucast_mgr.c: Add error numbers for some OSM_LOG prin

Hal Rosenstock hal.rosenstock at gmail.com
Sat Feb 14 09:03:12 PST 2009


Hi Sasha,

On Sat, Feb 14, 2009 at 11:22 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> Hi Hal,
>
> On 08:51 Sat 14 Feb     , hnrose at comcast.net wrote:
>>
>> From 3b8e45eaaeaac7bd34b60dfd432469cafc6caef7 Mon Sep 17 00:00:00 2001
>
> Please don't put this line ("From ...") in patch message body - it marks
> start of message in mbox file format and breaks things like 'git rebase'
> and similar. (At least mask this line with '> ' character).

Looks to me like it was >From but I'll try to remember to strip this.

>> From: Hal Rosenstock <hal.rosenstock at gmail.com>
>> Date: Tue, 10 Feb 2009 07:14:32 -0500
>> Subject: [PATCH] opensm/osm_ucast_mgr.c: Add error numbers for some OSM_LOG prints
>
> Actually there is no reason to repeat email header in a commit message.

So you just want the email subject and that stripped from the commit log ?

-- Hal

>>
>> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
>
> Applied. Thanks.
>
> Sasha
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>



More information about the general mailing list