[ofa-general] [PATCH 0/10 libibmad/infiniband-diags -- converting to "new" interface.

[Ira Weiny]

On Fri, 20 Feb 2009 08:55:57 -0500
Hal Rosenstock <hal.rosenstock at gmail.com> wrote:

> On Thu, Feb 19, 2009 at 10:05 PM, Ira Weiny <weiny2 at llnl.gov> wrote:
> > Here is v2 of the patch series.
> >
> > I used __attribute__ ((deprecated)) on the functions which should aid others
> > in realizing that these functions will go away.  (It sure helped me to convert
> > all the diags.
> >
> > Also I did _not_ convert ibnetdiscover as my new libibnetdisc already uses the
> > new interface and I am hoping it will be accepted soon.
> 
> A related issue is whether ibnetdiscover will support both the new
> library and the old way until the library is more proven via some
> build option. If it is to support both, then converting it should be
> done.

The conversion is easy.  I will do it for now to remove the build warnings.
And now that I think about it more leaving in the old and new code to be
chosen via configure is probably not a bad idea.  I don't know what is going
to happen once we standardize on the mad library for decoding strings.  There
are some incompatibilities there (ie 1x vs 1X and 2.5Gbps vs SDR etc.)

I will say, however, that I tested the library extensively and the first
version's output was identical to the old version with the sole exception of
the order ports were printed in.  :-D  So my confidence is high it will be
accepted sooner rather than later.

Ira

> 
> -- Hal
> 
> > The final patch converts perfquery, saquery, sminfo, smpquery, and vendstat
> > because they were all simple to convert and the patch series was getting
> > ridiculous.
> >
> > Thanks,
> > Ira
> >
> > --
> > Ira Weiny
> > Math Programer/Computer Scientist
> > Larence Livermore National Lab
> > weiny2 at llnl.gov
> > _______________________________________________
> > general mailing list
> > general at lists.openfabrics.org
> > http:// lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> >
> > To unsubscribe, please visit http:// openib.org/mailman/listinfo/openib-general
> >
> 


-- 
Ira Weiny
Math Programer/Computer Scientist
Larence Livermore National Lab
weiny2 at llnl.gov