[ofa-general] Re: [PATCH] libibmad/rpc.c: Handle redirection status

Sasha Khapyorsky sashak at voltaire.com
Tue Mar 10 08:47:25 PDT 2009


On 09:55 Tue 10 Mar     , Hal Rosenstock wrote:
> >
> > Basically it is about the same field.
> 
> One bit difference.
> 
> > Why do we need such flow?
> 
> Strict spec compliance.

Let's just mask this bit and we are done without long if/else/etc flow.

> > You are sending patches which cleans {} around single expressions...
> > Just wrap ERRS() macro with 'do {..} while (0)' and code will be
> > cleaner.
> 
> I'm not following what you mean by this.

IOW no need to put { } braces around single expression.

Sasha



More information about the general mailing list