***SPAM*** Re: [ofa-general] Re: [PATCH] libibmad/rpc.c: Handle redirection status

[Hal Rosenstock]

On Tue, Mar 10, 2009 at 10:47 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> On 09:55 Tue 10 Mar     , Hal Rosenstock wrote:
>> >
>> > Basically it is about the same field.
>>
>> One bit difference.
>>
>> > Why do we need such flow?
>>
>> Strict spec compliance.
>
> Let's just mask this bit and we are done without long if/else/etc flow.

Sure.

>> > You are sending patches which cleans {} around single expressions...
>> > Just wrap ERRS() macro with 'do {..} while (0)' and code will be
>> > cleaner.
>>
>> I'm not following what you mean by this.
>
> IOW no need to put { } braces around single expression.

Compiler complains about ambiguous else without this.

-- Hal

> Sasha
>