[openfabrics-ewg] Current OFED kernel snapshot

[Vladimir Sokolovsky]

Bryan O'Sullivan wrote:
> On Tue, 2006-05-02 at 11:36 +0300, Vladimir Sokolovsky wrote:
>
>   
>> ipath_core: Unknown symbol __iowrite32_copy
>>     
>
> Here's a patch to ipath_backport.h that should fix that.
>
> 	<b
>   
> ------------------------------------------------------------------------
>
> ===== ipath_backport.h 1.4 vs edited =====
> --- 1.4/drivers/infiniband/hw/ipath/ipath_backport.h	Wed Apr  5 19:12:26 2006
> +++ edited/ipath_backport.h	Wed May  3 22:15:09 2006
> @@ -83,6 +83,7 @@
>  #define mutex_unlock(foo) up(foo)
>  #endif
>  
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,16)
>  /*
>   * XXX - This is here for a short time only. See bug 8823.
>   *
> @@ -90,7 +91,17 @@
>   * for short copies, and does as well or slightly better than the
>   * optimizization guide copies 6 and 8 at 2KB.
>   */
> -void __iowrite32_copy(void __iomem * dst, const void *src, size_t count);
> +static inline void __iowrite32_copy(void __iomem * dst, const void *src, size_t count)
> +{
> +	u32 __iomem *dst = to;
> +	const u32 *src = from;
> +	const u32 *end = src + count;
> +
> +	while (src < end)
> +		__raw_writel(*src++, dst++);
> +}
> +#endif
> +
>  
>  /*
>   * XXX - Another short-term tenant.  See bug 8809.
>   
Bryan,
There is a compilation failure on Fedora Core 4  (kernel: 
2.6.11-1.1369_FC4).
That is after applying your last patch to ipath_backport.h.

Note: Your patch to ipath_backport.h was also problematic (compilation 
failed on all kernels):

See the fix:

-static inline void __iowrite32_copy(void __iomem * dst, const void *src, size_t count)
+static inline void __iowrite32_copy(void __iomem * to, const void *from, size_t count)

It was fixed and checked in into tags/rc4 by Jack.

/_Compilation failure log:_/
In file included from 
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath/ipath_qp.c:36:
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath/ipath_backport.h: 
In function â__iowrite32_copyâ:
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath/ipath_backport.h:101: 
warning: implicit declaration of function â__raw_writelâ
In file included from include/asm/dma.h:18,
                 from include/asm/scatterlist.h:14,
                 from 
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/include/rdma/ib_verbs.h:48,
                 from 
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/include/rdma/ib_pack.h:38,
                 from 
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath/ipath_verbs.h:40,
                 from 
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath/ipath_qp.c:37:
include/asm/io.h: At top level:
include/asm/io.h:103: warning: conflicting types for â__raw_writelâ
include/asm/io.h:103: error: static declaration of â__raw_writelâ 
follows non-static declaration
/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath/ipath_backport.h:101: 
error: previous implicit declaration of â__raw_writelâ was here
make[3]: *** 
[/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath/ipath_qp.o] 
Error 1
make[2]: *** 
[/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband/hw/ipath] 
Error 2
make[1]: *** 
[_module_/tmp/openib_gen2/openib_branch1.0/src/linux-kernel/infiniband] 
Error 2
make[1]: Leaving directory `/usr/src/kernels/2.6.11-1.1369_FC4-ppc64'
make: *** [kernel] Error 2

Bryan, please check, at least compilation, before sending us any patches.

Regards,
Vladimir