[ewg] Re: [PATCH 2/14] nes: device structures and defines

[David Miller]

From: Andi Kleen <andi at firstfloor.org>
Date: 08 Aug 2007 14:38:10 +0200

> Jeff Garzik <jeff at garzik.org> writes:
> > > +			val, reg_index, addr, addr+4); */
> > > +	writel(cpu_to_le32(reg_index), addr);
> > > +	writel(cpu_to_le32(val),(u8 *)addr + 4);
> > 
> > wrong -- endian conversion macros not needed with writel()
> 
> Are you sure? I don't think that's true. e.g. powerpc writel 
> doesn't convert endian

raw_writel() doesn't, but writel() does.

Why not look at the code, as I did, instead of "think"ing? :-)