[openfabrics-ewg] VNIC backport patches are whitespace-damaged

Vladimir Sokolovsky vlad at mellanox.co.il
Wed Jan 24 09:59:09 PST 2007


On Wed, 2007-01-24 at 11:51 -0600, Ramachandra Kuchimanchi wrote:
> Vlad,
> 
> Roland merged these fixes into his vex branch. If you
> can pull in the latest VNIC kernel driver code from Roland's vex
> branch then these VNIC patches can be removed from the fixes directory of OFED.
> If that is not possible, please let me know so that I can re-submit the patches. 
> 

Ram,
Send me please the git URL of the Roland's vex branch.

> Bryan,
> 
> Thanks for the patches, but your version of the second patch does not seem to
> be exactly what I want. So if Vlad requires the patches, I will re-submit both
> of them anyway. 
> 
> The original version of these patches did not have any whitespace issues.
> I guess these crept in when the inline patches were saved as files (probably by copy pasting)
> in the fixes directory. And since the OFED kernel configure script applies these
> patches with patch -l (to ignore whitespaces) and the build process was successful,
> I never realized this issue.
> 

I also don't see any issues with the original patches. The ofa_kernel
daily build process passed successfully.

> Regards,
> Ram

-- 
Vladimir Sokolovsky <vlad at mellanox.co.il>
Mellanox Technologies Ltd.




More information about the ewg mailing list