[ewg] Re: [ofa-general] OFED 1.2 Feb-26 meeting summary

[Doug Ledford]

On Mon, 2007-03-19 at 17:20 +0200, Michael S. Tsirkin wrote:
> > The kernel code will
> > always match the openib package.  When I update one, I update the other.
> > So, you always know the base by looking at the openib package version,
> > and then you can see any additional patches I've applied to user space
> > by looking at the openib.spec file, and you can see additional patches
> > to the kernel by looking for the main OFED patch (in RHEL4, it's patch
> > 2700, in RHEL5 it's patch 2600), and immediately after or before the
> > main update patch will be the individual change patches that we've
> > applied.
> 
> You lost me here. Example?

From the RHEL4 kernel spec file:
# OpenIB Infiniband patches
Patch2700: linux-2.6.9-OFED-1.1.patch
Patch2701: linux-2.6.9-spinlock-define.patch
Patch2702: linux-2.6.9-if_infiniband.patch
Patch2703: linux-2.6.9-gfp_t-typedef.patch
Patch2704: linux-2.6.9-empty-debugfs.patch
Patch2705: linux-2.6.9-pci_find_next_cap.patch
Patch2706: linux-2.6.9-wait_for_completion_timeout.patch
Patch2707: linux-2.6.9-OpenIB-build.patch
Patch2708: linux-2.6.9-OpenIB-read_mostly.patch
Patch2709: linux-2.6.9-OpenIB-flush_core_git.patch
Patch2710: linux-2.6.9-OpenIB-flush_users.patch
Patch2711: linux-2.6.9-OpenIB-mad_rmpp_requester_retry.patch
Patch2712: linux-2.6.9-OpenIB-srp_avoid_null_deref.patch
Patch2713: linux-2.6.9-OpenIB-4g-dma.patch
Patch2714: linux-2.6.9-scsi_scan_target-export.patch
Patch2715: linux-2.6.9-mutex-backport.patch
# Uncertain patches
Patch2720: linux-2.6.9-OpenIB-rdma_misc.patch
Patch2721: linux-2.6.9-OpenIB-sa_pack_unpack.patch

To see which of those patches are actually applied to the kernel, search
for %patch2700 and look from there.  Currently, that looks like this:
# OpenIB Infiniband support
%patch2700 -p1
%patch2701 -p1
%patch2702 -p1
%patch2703 -p1
%patch2704 -p1
%patch2705 -p1
%patch2706 -p1
%patch2707 -p1
%patch2708 -p1
%patch2709 -p1
%patch2710 -p1
%patch2711 -p1
%patch2712 -p1
%patch2713 -p1
%patch2714 -p1
%patch2715 -p1
# Don't apply these two for now
#%patch2720 -p1
#%patch2721 -p1

So, you can see what the patches are, and which are or aren't applied.
The easiest way to see if something you are interested in is applied
would be to do a rpmbuild --bp kernel-2.6.spec from where ever you
installed the kernel src.rpm files into, then diff just the
drivers/infiniband tree of that kernel repo against the one that has all
the fixes you are interested in already applied and examine the
difference.  Of course, be aware that since we patch some things in the
core kernel that you guys patch up in your code instead, there will be a
non-trivial amount of noise in the diff because of that.


From the RHEL5 kernel spec file:
# Infiniband driver
Patch2600: linux-2.6-openib-sdp.patch
Patch2601: linux-2.6-openib-ehca.patch
Patch2602: linux-2.6-openib-ofed-1_1-update.patch


> The OFED support page
> https://wiki.openfabrics.org/tiki-index.php?page=OFED+Support
> mentions patches for two critical bugs in kernel code:
> 
> IPoIB kernel oops, and mthca off-by-one.
> 
> Are these two applied? How to find out?

Neither are applied to RHEL5, but that's not surprising given that it's
out the door already which means it froze long ago.  For RHEL4.5, I
*might* be able to get them in.  We'll see.

-- 
Doug Ledford <dledford at redhat.com>
              GPG KeyID: CFBFF194
              http://people.redhat.com/dledford

Infiniband specific RPMs available at
              http://people.redhat.com/dledford/Infiniband
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/ewg/attachments/20070320/f70a72c6/attachment.sig>