[ewg] Re: [ofa-general] [PATCH 1/1] RPM Spec files

[Erez Zilber]

Mike Heinz wrote:

> Installation of OFED 1.3.0.0.4 onto a Kusu/OCS cluster does not fully
> succeed because of some missing dependencies in the RPM spec files. This
> is because Kusu installs nodes over a network by presenting a pool of
> RPMs to be installed and letting RPM figure out the order to install
> them in. Without the dependencies we ended up with oddities like the
> kernel drivers being installed before the /usr/bin directory had been
> populated, causing the install script to fail.
>  
> I was able to work around this by manually expanding some of the source
> RPM files, altering the spec file and repackaging the source RPM. This
> allowed me to build binary RPMs (via the install script) that could be
> installed on a Kusu cluster.
>  
> Here are the proposed changes. If there is a better/preferred way of
> submitting this suggestion, please let me know.
>   

Some general comments:

    * OFED issues are discussed in the ewg list. You should send patches
      to that list.
    * You have patches for multiple git trees (bonding, open-iscsi etc).
      You should separate them to multiple patches. Each patch should
      have a separate e-mail message (and add the maintainer to the
      thread). The best thing to do is to create a patch set.
    * Please create the patches against the relevant git trees. It will
      make it easier to apply them.

See more comments below.

>  
> --- ../../original/ib-bonding.spec      2008-04-22 12:54:12.000000000
> -0400
> +++ ib-bonding.spec     2008-04-22 12:43:07.000000000 -0400
> @@ -20,6 +20,7 @@
>  Group           : Applications/System
>  License         : GPL
>  BuildRoot:      %{_tmppath}/%{name}-%{version}-root
> +PreReq         : coreutils
>  
>  %description
>  This package provides a bonding device which is capable of enslaving
> --- ../../original/ofa_kernel.spec      2008-04-22 12:54:13.000000000
> -0400
> +++ ofa_kernel.spec     2008-04-22 12:45:40.000000000 -0400
> @@ -111,6 +111,9 @@
>  BuildRequires: sysfsutils-devel
>  
>  %package -n kernel-ib
> +PreReq: coreutils
> +PreReq: kernel
> +PreReq: pciutils
>  Version: %{_version}
>  Release: %{krelver}
>  Summary: Infiniband Driver and ULPs kernel modules
> @@ -119,6 +122,10 @@
>  Core, HW and ULPs kernel modules
>  
>  %package -n kernel-ib-devel
> +PreReq: coreutils
> +PreReq: kernel
> +PreReq: pciutils
> +Requires: kernel-ib
>  Version: %{_version}
>  Release: %{krelver}
>  Summary: Infiniband Driver and ULPs kernel modules sources
> --- ../../original/open-iscsi-generic.spec      2008-04-22
>   

If this change is relevant for open-iscsi.git, it is also relevant for
open-iscsi-rh4.git. BTW - you can see the list of git trees here:
http://www.openfabrics.org/git/

Erez