[ewg] Re: [PATCH] ipoib: disable napi while cq is being drained

Vladimir Sokolovsky vlad at mellanox.co.il
Sun Apr 19 03:24:47 PDT 2009


On Fri, 2009-04-17 at 18:26 +0300, Yossi Etigin wrote:
> If napi is enabled while cq is being drained, it creates a race on
> priv->ibwc
> between ipoib_poll and ipoib_drain_cq, leading to memory corruption.
>  The solution is to enable/disable napi in ipoib_ib_dev_open/stop
> instead of in
> ipoib_open/stop, and sync napi on INITIALIZED bit instead on ADMIN_UP
> bit. This
> way napi will be disabled when ipoib_drain_cq is called.
> This fixes bugzilla #1587.
> 
> Signed-off-by: Yossi Etigin <yosefe at voltaire.com>
> 
> ---

Applied,

Regards,
Vladimir



More information about the ewg mailing list