[ewg] [PATCH] ipoib: disable napi while cq is being drained

[Jack Morgenstein]

On Friday 17 April 2009 18:26, Yossi Etigin wrote:
> -       ipoib_dbg(priv, "bringing up interface\n");
> - 
> --      if (!test_and_set_bit(IPOIB_FLAG_ADMIN_UP, &priv->flags))
> --              napi_enable(&priv->napi);
> -+      set_bit(IPOIB_FLAG_ADMIN_UP, &priv->flags);
> - 
> -       if (ipoib_pkey_dev_delay_open(dev))
> -               return 0;
> - 
> --      if (ipoib_ib_dev_open(dev)) {
> --              napi_disable(&priv->napi);
> --              return -EINVAL;
> --      }
> -+      if (ipoib_ib_dev_open(dev))
> -+              return -EINVAL;
> 

I think there is a bug here in the error flow. 
You do
   set_bit(IPOIB_FLAG_ADMIN_UP, &priv->flags);

However, if there is an error return, you do not do
   clear_bit(IPOIB_FLAG_ADMIN_UP, &priv->flags);

Note that in the patch you prepared for Roland (in the general list),
the clear_bit is done properly.
(you probably need to arrange for an "err_out:" goto label which will do
the clear_bit and return -EINVAL).

- Jack

P.S. we need the fix for ofed 1.4.1 ASAP.