[ewg] Re: [ofw] SC'09 BOF - Meeting notes

[Or Gerlitz]

Liran Liss wrote:
> The patches don't change the logic of existing flows at all, so we are
> not risking *anything* in terms of the stability of the current stack.

I understand that this is your assessment of the situation, looking on the series present 
at the ofed1.5 rdmaoe branch in a black box manner yields that many many files are touched, see below. Coming and saying that changes in your HW LL driver are out of the scope for other companies to discuss is not acceptable, since we provide enterprise ready stack based on your HW driver.

> As for vlan id and priorities - we are fully aware to the importance of
> exposing vlan ids and priorities to the user, but thanks for pointing this out.

sure, I am saying this since my first look on the patches, couple of months ago, good that someone listens now.

> There are deployments today that work fine with the current patches

all the rdmaoe materials saying the lossless traffic class is a must, are you saying that this works well also without it? then why from architect point of view you have posed this requirement?

Or.

$ cat rdmaoe_patches

core_0300_refine_device_personality.patch
core_0310-Add-RDMAoE-transport-protocol.patch
core_0320_rdmaoe_support_qp1.patch
core_0330_umad-Enable-support-only-for-IB-ports.patch
core_0340_Enable-CM-support-for-RDMAoE.patch
core_0350-CMA-device-binding.patch
core_0360_RDMAoE-UD-packet-packing-support.patch
core_0370-support-RDMAoE-from-userspace.patch
core_0380_mcast-support-to-rdmaoe.patch
core_0390_cma-move-netdev-mac.patch
mlx4_2000_RDMAoE-address-resolution.patch
mlx4_2010_RDMAoE-support-allow-interfaces-to-correspond.patch
mlx4_2020_handle_mcast_mac.patch
mlx4_2030_fix_port_num.patch
mlx4_2040_Fix-multicast-handling.patch
xxx_rdmaoe_port_notice.patch

$ cat rdmaoe_patches | xargs diffstat 

 b/drivers/infiniband/core/cm.c                          |   25 -
 b/drivers/infiniband/core/cma.c                         |   54 +-
 b/drivers/infiniband/core/mad.c                         |   41 +-
 b/drivers/infiniband/core/multicast.c                   |    4 
 b/drivers/infiniband/core/sa_query.c                    |   39 +-
 b/drivers/infiniband/core/ucm.c                         |    8 
 b/drivers/infiniband/core/ucma.c                        |    2 
 b/drivers/infiniband/core/user_mad.c                    |    6 
 b/drivers/infiniband/core/verbs.c                       |   25 +
 b/drivers/infiniband/hw/mlx4/main.c                     |   56 ++
 b/drivers/infiniband/ulp/ipoib/ipoib_main.c             |   12 
 b/include/rdma/ib_addr.h                                |   93 ++++
 b/include/rdma/ib_verbs.h                               |   11 
 b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c               |    3 
 b/net/sunrpc/xprtrdma/svc_rdma_transport.c              |    3 
 drivers/infiniband/core/cm.c                            |    5 
 drivers/infiniband/core/cma.c                           |  254 +++++++++++--
 drivers/infiniband/core/ucm.c                           |   13 
 drivers/infiniband/core/ucma.c                          |   31 +
 drivers/infiniband/core/user_mad.c                      |   16 
 drivers/infiniband/hw/mlx4/ah.c                         |   22 -
 drivers/infiniband/hw/mlx4/main.c                       |  110 ++++-
 drivers/infiniband/hw/mlx4/mlx4_ib.h                    |   13 
 drivers/infiniband/hw/mlx4/qp.c                         |   29 +
 include/rdma/ib_verbs.h                                 |    4 
 ofed_kernel-fixes/drivers/infiniband/core/agent.c       |   39 +-
 ofed_kernel-fixes/drivers/infiniband/core/local_sa.c    |   22 -
 ofed_kernel-fixes/drivers/infiniband/core/mad.c         |   45 +-
 ofed_kernel-fixes/drivers/infiniband/core/notice.c      |    4 
 ofed_kernel-fixes/drivers/infiniband/core/ud_header.c   |  111 +++++
 ofed_kernel-fixes/drivers/infiniband/core/uverbs.h      |    1 
 ofed_kernel-fixes/drivers/infiniband/core/uverbs_cmd.c  |   32 +
 ofed_kernel-fixes/drivers/infiniband/core/uverbs_main.c |    1 
 ofed_kernel-fixes/drivers/infiniband/core/verbs.c       |    9 
 ofed_kernel-fixes/drivers/infiniband/hw/mlx4/ah.c       |  187 +++++++--
 ofed_kernel-fixes/drivers/infiniband/hw/mlx4/mad.c      |   32 +
 ofed_kernel-fixes/drivers/infiniband/hw/mlx4/main.c     |  309 ++++++++++++++--
 ofed_kernel-fixes/drivers/infiniband/hw/mlx4/mlx4_ib.h  |   19 
 ofed_kernel-fixes/drivers/infiniband/hw/mlx4/qp.c       |  169 ++++++--
 ofed_kernel-fixes/drivers/net/mlx4/en_main.c            |   15 
 ofed_kernel-fixes/drivers/net/mlx4/en_port.c            |    4 
 ofed_kernel-fixes/drivers/net/mlx4/en_port.h            |    3 
 ofed_kernel-fixes/drivers/net/mlx4/fw.c                 |    3 
 ofed_kernel-fixes/drivers/net/mlx4/intf.c               |   20 +
 ofed_kernel-fixes/drivers/net/mlx4/main.c               |    6 
 ofed_kernel-fixes/drivers/net/mlx4/mlx4.h               |    1 
 ofed_kernel-fixes/include/linux/mlx4/cmd.h              |    1 
 ofed_kernel-fixes/include/linux/mlx4/device.h           |   31 +
 ofed_kernel-fixes/include/linux/mlx4/driver.h           |   16 
 ofed_kernel-fixes/include/linux/mlx4/qp.h               |    8 
 ofed_kernel-fixes/include/rdma/ib_pack.h                |   26 +
 ofed_kernel-fixes/include/rdma/ib_user_verbs.h          |   19 
 ofed_kernel-fixes/include/rdma/ib_verbs.h               |   12 
 53 files changed, 1675 insertions(+), 349 deletions(-)