[ewg] T3 change needed for OFED-1.5.4

[Steve Wise]

On 09/14/2011 12:58 PM, Hefty, Sean wrote:
> I got lost here.
>
> The librdmacm has release 1.0.14.  This included previous fixes.  Release 1.0.14.1 reverted commit 93635fa33b41d356fa096242fec4ce788194b42f from the 1.0.14 release.
>
> So... if you want commit 93635fa33b41d356fa096242fec4ce788194b42f, then release 1.0.14 should work.  If you don't want it, release 1.0.14.1 is needed.  If you want the commit, but also want a version number after 1.0.14.1, I need to push out a new release.  :)
>
> I may be able to create a new release depending on how entwined xrc support has become in the librdmacm code base. :P  Can you let me know which option you're looking for?

So I think we want the bits of 1.0.14.  I'm ok with just changing OFED-1.5.4 to use that vs making a new release if 
that's ok with everyone (sort of backing up release number-wise).


> - Sean
>
>> -----Original Message-----
>> From: Steve Wise [mailto:swise at opengridcomputing.com]
>> Sent: Wednesday, September 14, 2011 7:55 AM
>> To: Hefty, Sean
>> Cc: Vladimir Sokolovsky; Tziporet Koren; OpenFabrics EWG; Divy Le Ray; Kumar A
>> S; Vipul Pandya
>> Subject: T3 change needed for OFED-1.5.4
>>
>>
>> Hey Sean,
>>
>> Do you remember we pulled out 2 upstream rping fixes in ofed-1.5.2 (or maybe
>> 1.5.3) because of a regression that was due
>> to a change in iw_cxgb3/libcxgb3 that was not included in 1.5.2.  The commits
>> are below.  Anyway, I want to pull this
>> iw_cxgb3/libcxgb3 change into OFED-1.5.4 and I'll need the 2 rping fixes
>> pulled in also.
>>
>> We need this because the T4 iwarp driver/lib has this same functionality that
>> isn't in the OFED T3 code. With this
>> functionality, rping is broken and needs the 2 librdmacm fixes.  However, if
>> you pull in the 2 librdmacm fixes, then the
>> existing T3 code will cause rping to hang, I think, which is why we pulled the
>> rping changes from OFED-1.5.2.  So we
>> need to bring T3 up to date, and get these librdmacm fixes pulled in.
>>
>> Can you please submit the librdma release that includes these rping changes
>> once we get the T3 changes included?
>>
>> Here are the details:
>>
>> We need this iw_cxg3 upstream fix.  Chelsio will do this asap.
>>
>> commit b955150ea784af4c193b708a2e8091673bf23004
>> Author: Steve Wise<swise at opengridcomputing.com>
>> Date:   Thu Oct 21 12:37:06 2010 +0000
>>
>>       RDMA/cxgb3: When a user QP is marked in error, also mark the CQs in error
>>
>>
>> Also we need these librdmacm changes:
>>
>> commit 93635fa33b41d356fa096242fec4ce788194b42f
>> Author: Sean Hefty<sean.hefty at intel.com>
>> Date: Mon Nov 1 11:12:13 2010 -0700
>>
>> librdmacm/rping: Make sure CQ event thread exits before destroying the CQ
>>
>>
>> commit 8c6aeb3e70bbf275f9b618775133b9ae6f07ad15
>> Author: Steve Wise<swise at opengridcomputing.com>
>> Date: Wed Oct 20 12:34:55 2010 -0700
>>
>> RPING: Remove printf for FLUSH completion.
>>
>>
>> And finally, we need to pull in libcxgb3-1.3.0.
>>