Intent to remove ts_kernel_trace WAS[Re: [openib-general] [PATCH] kill ib_legacy.h]
Roland Dreier
roland at topspin.com
Fri Aug 13 18:14:42 PDT 2004
Tom> So, I would like to go through and get rid of TS_TRACE and
Tom> replace with standard printk.
Tom> What do people think?
Some TS_TRACE messages can be directly replaced with printk (although
in some cases dev_printk might be nice to get a little more info
printed). For example stuff like
TS_REPORT_WARN(MOD_KERNEL_IB,
"Device %s is missing mandatory function %s",
device->name, mandatory_table[i].name);
return -EINVAL;
(in core_device.c) can obviously be replaced with a printk(KERN_ERR ...).
However most of the trace messages (probably everything at level
VERBOSE and above) are for debugging and need to be wrapped in #ifdef
DEBUG or (better) dynamically controlled with a debug level settable
through sysfs.
For example most of the tracing in cm_*.c is way too verbose to printk
all the time (even at level KERN_DEBUG).
- R.
More information about the general
mailing list