Intent to remove ts_kernel_trace WAS[Re: [openib-general] [PATCH] kill ib_legacy.h]

[Tom Duffy]

On Fri, 2004-08-13 at 18:14 -0700, Roland Dreier wrote:
> Some TS_TRACE messages can be directly replaced with printk (although
> in some cases dev_printk might be nice to get a little more info
> printed).  For example stuff like
> 
> 			TS_REPORT_WARN(MOD_KERNEL_IB,
> 				       "Device %s is missing mandatory function %s",
> 				       device->name, mandatory_table[i].name);
> 			return -EINVAL;
> 
> (in core_device.c) can obviously be replaced with a printk(KERN_ERR ...).

Fair enough.

> However most of the trace messages (probably everything at level
> VERBOSE and above) are for debugging and need to be wrapped in #ifdef
> DEBUG or (better) dynamically controlled with a debug level settable
> through sysfs.

How about I put all VERBOSE and above in a dbg() function only defined
when DEBUG is set?  This is how USB does it.

> For example most of the tracing in cm_*.c is way too verbose to printk
> all the time (even at level KERN_DEBUG).

That is true.

-tduffy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20040816/0483749e/attachment.sig>