[openib-general] [PATCH] ib_mad: In completion handler, when status != success call send done handler

[Sean Hefty]

On Wed, 27 Oct 2004 10:20:05 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> On Tue, 2004-10-26 at 12:50, Sean Hefty wrote:
> > I think we have other issues with the completion handling as well.  
> > Since we use a single CQ for both QPs, I think that we need to search 
> > the send_posted_mad_list to find the corresponding completion.  
> > We cannot assume that the completion matches with the request at the 
> > head of the list.
> > 
> > This appears to be broken in the non-error case as well.
> > 
> > I will happily create a patch to fix these issues.
> 
> Is it worth fixing this for the current approach or should I just wait
> for this patch ?

I'll create a patch that uses separate send_posted_mad_list's for QP0/1, but try to keep the changes fairly minimal.  I'll do this after changing the completion handling to use the current workqueue, rather than allocating a separate thread.  (I've canned my user-mode work, since Roland is further along.)

- Sean