[openib-general] [PATCH] ib_mad: In completion handler, when status != success call send done handler

[Sean Hefty]

On Wed, 27 Oct 2004 09:53:28 -0700
Sean Hefty <mshefty at ichips.intel.com> wrote:


> I'll create a patch that uses separate send_posted_mad_list's for
> QP0/1, but try to keep the changes fairly minimal.  I'll do this after
> changing the completion handling to use the current workqueue, rather
> than allocating a separate thread.  (I've canned my user-mode work,
> since Roland is further along.)

I've run into a few other issues trying to use separate send queues. 
One of note is that receives are posted to the QP outside of the lock
that inserts them onto the recv_posted_mad_list.  I don't think that
this causes a problem at the moment, since receives are always re-posted
from the completion handler, which is single threaded.

Question then, should I go ahead and fix this so that it would work in a
multi-threaded case, or assume that completion handling will be single
threaded and optimize for this by removing unnecessary locking? 
(Currently, my patch fixes the locking, but it should be noted that the
code won't actually test that the locking is correct as it's written.)

- Sean